feat: allow applying the tooltip to a specific layer #1399
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eoxelements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
StefanBrand
reviewed
Dec 2, 2024
| @@ -8,6 +8,7 @@ export class EOxMapTooltip extends LitElement { | |||
| static get properties() { | |||
| return { | |||
| feature: { attribute: false, property: true, type: Object }, | |||
| for: { attribute: "for", property: true, type: String }, | |||
There was a problem hiding this comment.
Usually for is used for DOM specifiers. Maybe we should use a different property for the layer ID.
|
Closing in favor of #1409 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented changes
This introduces an option to provide a layer id for the
eox-maptooltip. By default the tooltip renders for the topmost interaction layer, but can be set to specifically render for one layer:Related to #1358, #594
Screenshots/Videos
Screencast.from.2024-11-27.15.36.32.webm
Checklist before requesting a review